Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @guptask)

cachelib/CMakeLists.txt line 89 at r1 (raw file):

# Add code coverage
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage -fprofile-arcs -ftest-coverage")

Can add an option to enable/disable coverage?

Something like:

if(COVERAGE_ENABLED)
    # Add code coverage
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage -fprofile-arcs -ftest-coverage")
endif()

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @guptask)

run_code_coverage.sh line 11 at r2 (raw file):

# Track coverage
lcov -c -i -b . -d . -o Coverage.baseline

what is this Coverage.baseline? what does it contain if no tests were run?

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @guptask)

run_code_coverage.sh line 3 at r2 (raw file):

#!/bin/bash

BUILD_DIR='build-cachelib'

I'm not sure if you should put compilation/installation step here - it would be better for this script to be standalone.

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @guptask)

run_code_coverage.sh line 3 at r2 (raw file):

I mean, I'm not sure if we need the build script at all. We can just document what flag you need to pass to cmake to enable coverage.

run_code_coverage.sh line 11 at r2 (raw file):

Ok, got it.